Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for exception thrown by GPOLocalGroupProcessor #142

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Fix for exception thrown by GPOLocalGroupProcessor #142

merged 4 commits into from
Jul 26, 2024

Conversation

rvazarkar
Copy link
Contributor

Description

GpoLocalGroupProcessor was not properly providing a domain to the query function.

Motivation and Context

How Has This Been Tested?

Local testing

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

@juggernot325 juggernot325 self-requested a review July 26, 2024 18:44
rvazarkar added 2 commits July 26, 2024 15:01
@rvazarkar
chore: fix broken tests
925f168 
fix: make gpolocalgroup processor a bit smarter
@rvazarkar
chore: fix tests
5bc46d3
juggernot325
juggernot325 reviewed Jul 26, 2024
View reviewed changes
Copy link
Contributor

@juggernot325 juggernot325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions about the test changes. If that all looks good I'm ready to approve it!

test/unit/GPOLocalGroupProcessorTest.cs Outdated Show resolved Hide resolved
test/unit/GPOLocalGroupProcessorTest.cs Outdated Show resolved Hide resolved
@rvazarkar rvazarkar merged commit 8102ec1 into v4 Jul 26, 2024
3 checks passed
@rvazarkar rvazarkar deleted the patches branch July 26, 2024 20:02
@github-actions github-actions bot locked and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juggernot325 juggernot325 juggernot325 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rvazarkar @juggernot325